search

epicweb-dev / epic-stack

This is a Full Stack app starter with the foundational things setup and configured for you to hit the ground running on your next EPIC idea.
https://www.epicweb.dev/epic-stack
MIT License
4.32k stars 355 forks source link

Inquiry: Is the authenticator not using the connection session? #750

Closed natac13 closed 3 months ago

natac13 commented 3 months ago

https://github.com/epicweb-dev/epic-stack/blob/7923be98dc8a3338b70619ea828f1048afe816bf/app/routes/_auth%2B/onboarding_.%24provider.tsx#L94

Im curious if this line should be trying to get the authenticator error from the connectionSessionStorage which is what is passed to the Authenticator constructor. Would the authenticator, upon failure not put the error on the connection session? How does the remix authenticator know about the auth session. I could be mistaken but I was under the impression that the Epic Stack does not use remix-auth directly to manage the session. But instead only pass around a user profile when the user uses the provider.

kentcdodds commented 3 months ago

I think you're right! I don't know how remix-auth would get the session error in the authSession to begin with. PR is welcome :)