epicweb-dev / epic-stack

This is a Full Stack app starter with the foundational things setup and configured for you to hit the ground running on your next EPIC idea.
https://www.epicweb.dev/epic-stack
MIT License
4.32k stars 355 forks source link

remove redundant sourcemap flags #784

Closed nichtsam closed 2 months ago

nichtsam commented 2 months ago

Test Plan

Checklist

Screenshots

kiliman commented 2 months ago

I'm pretty sure you need those flags to get sourcemaps on a production build. I'm not sure what is meant by "redundant".

nichtsam commented 2 months ago

I'm not sure how to verify this, here are what I checked:

I built

I went to check the source code of remix vite:build, and I believe what the flags do is setting build.sourcemap = true for their own environment, which is the same as setting it in vite.config.ts. https://github.com/remix-run/remix/blob/main/packages/remix-dev/vite/build.ts#L229

In addition, my own project only have build.sourcemap = true and doesn't have flags, it's working.

kentcdodds commented 2 months ago

Thanks!