search

epicweb-dev / epic-stack

This is a Full Stack app starter with the foundational things setup and configured for you to hit the ground running on your next EPIC idea.
https://www.epicweb.dev/epic-stack
MIT License
4.32k stars 355 forks source link

build(deps): remove `chalk` and use `styleText` instead #798

Closed kinggoesgaming closed 1 week ago

kinggoesgaming commented 1 month ago

Test Plan

No tests or docs need changing

Screenshots

No change that requires diff of screenshots

closes: #792

jacobparis commented 1 month ago

styleText doesn't land until Node 22 (node 21.7 technically) which won't be LTS until October, so I don't think we can merge this until then based on this decision doc

https://github.com/epicweb-dev/epic-stack/blob/main/docs/decisions/021-node-version.md

kinggoesgaming commented 1 month ago

styleText doesn't land until Node 22 (node 21.7 technically) which won't be LTS until October, so I don't think we can merge this until then based on this decision doc

https://github.com/epicweb-dev/epic-stack/blob/main/docs/decisions/021-node-version.md

I am so used to using it that I didn't realize it is still in Active development stage.

I will try to keep this PR up-to-date until it is stablized.

kinggoesgaming commented 1 month ago

Another point: this does not actually remove chalk from the dependency tree, as other dependencies do depend on chalk, but now it is a transitive dev dependency.

alcpereira commented 1 month ago

styleText doesn't land until Node 22 (node 21.7 technically) which won't be LTS until October, so I don't think we can merge this until then based on this decision doc

https://github.com/epicweb-dev/epic-stack/blob/main/docs/decisions/021-node-version.md

What do you think about updating the requirement to Node 20.12.0?

I'm used to work with .nvmrc or .node-version files so that Node version manager like fnm can select the right version for the project. Is it worth opening a PR to add one of those (with corresponding documentation)? So it might also unblock this PR. Edit: This is already suggested in #799

kentcdodds commented 1 month ago

Why don't node managers reference the engines config in the package.json? I'd really rather avoid adding an extra file to the root just for the node version.

kentcdodds commented 1 week ago

I'm going to close this for now. We can revisit when Node 22 is our base.