search

epicweb-dev / epic-stack

This is a Full Stack app starter with the foundational things setup and configured for you to hit the ground running on your next EPIC idea.
https://www.epicweb.dev/epic-stack
MIT License
4.32k stars 355 forks source link

Remove `installGlobals` calls #802

Closed kinggoesgaming closed 1 month ago

kinggoesgaming commented 1 month ago

The globals added by installGlobals are now natively available with node 20+

Ref: https://github.com/remix-run/remix/issues/7067#issuecomment-2225843886

kinggoesgaming commented 1 month ago

Ok I think I might have misunderstood that comment. Need a second opinion before I anything here

kinggoesgaming commented 1 month ago

Ok I think I might have misunderstood that comment. Need a second opinion before I anything here

Looking further.. I am correct on the fact that installGlobals is no longer needed

kentcdodds commented 1 month ago

Yeah, we can remove that I think