search

epicweb-dev / epicshop

The workshop app for all workshops on EpicWeb.dev
https://www.epicweb.dev
Other
207 stars 33 forks source link

Make diff lines show line number on hover #115

Closed kentcdodds closed 1 year ago

kentcdodds commented 1 year ago

These can get rather long and it could be handy to display the line number when the user hovers over that area:

image

To be clear, not on hover of the line (that would be annoying), but if the user hovers the + or - it should switch to the line number it represents.

onemen commented 1 year ago

diff

do you think we can do github diff?

kentcdodds commented 1 year ago

I think that takes up too much space. The line numbers aren't important enough to take up that much space.

onemen commented 1 year ago

To be clear, not on hover of the line (that would be annoying), but if the user hovers the + or - it should switch to the line number it represents.

it is not possible to apply a :hover pseudo-class directly to a :before or :after pseudo-element.

kentcdodds commented 1 year ago

Ah, I worried about that. Oh well. Not worth the complexity or effort then.