search

epicweb-dev / epicshop

The workshop app for all workshops on EpicWeb.dev
https://www.epicweb.dev
Other
205 stars 33 forks source link

(destructured parameter) is undefined #215

Closed RobbertWolfs closed 2 months ago

RobbertWolfs commented 2 months ago

Clicking the "Files" button results in the following error:

image

image

image

kentcdodds commented 2 months ago

Fixed in https://github.com/epicweb-dev/epicshop/commit/e13eed56a8d1ebf9bdab02b7be10b47917cab738 (forgot to mention this issue in the commit).

Thanks for reporting!

This is the reason it's best to not use useLoaderData outside the route that has the loader in it. Too easy to miss something in a refactor 😅

RobbertWolfs commented 2 months ago

Thanks for the quick fix 🚀