search

epicweb-dev / epicshop

The workshop app for all workshops on EpicWeb.dev
https://www.epicweb.dev
Other
207 stars 33 forks source link

rocket rental exercises not working inside workshop-app #51

Closed onemen closed 1 year ago

onemen commented 1 year ago

the fix for this issue https://github.com/epicweb-dev/testing-web-apps/issues/3 in here.

this is the fix in process-manager.server.ts runAppDev, maybe runAppTests need the same fix but i did not test it

    const appProcess = spawn('npm', ['run', 'dev'], {
        cwd: app.fullPath,
        shell: true,
+       stdio: ['inherit', 'pipe', 'pipe'],
        env: {
            ...process.env,
            // TODO: support specifying the env
            NODE_ENV: 'development',
            // TODO: support specifying the port
            PORT: String(portNumber),
            APP_SERVER_PORT: String(portNumber),
            // let it pick a random port...
            REMIX_DEV_SERVER_WS_PORT: '',
        },
    })
kentcdodds commented 1 year ago

Whoops, closed this with the last commit: 1ffa3de22f8dfaa7d308902b297f475f037e38b4