search

epicweb-dev / react-fundamentals

Material for my React Fundamentals Workshop
https://fundamentals.epicreact.dev
Other
5.29k stars 3.2k forks source link

Union -> Intersection #372

Closed Creeland closed 2 months ago

Creeland commented 2 months ago

https://github.com/epicweb-dev/react-fundamentals/blob/44fe088588cc5287386e6ae015359cadba3bcc28/exercises/06.styling/03.problem.size-prop/index.tsx#L3-L11

In the problem there's a hint that says to union this with an object but it looks like you're using an intersection in the solution.

https://github.com/epicweb-dev/react-fundamentals/blob/44fe088588cc5287386e6ae015359cadba3bcc28/exercises/06.styling/03.solution.size-prop/index.tsx#L6-L8

Would it make sense to add a docs link in the problem README and change the hint here?

kentcdodds commented 2 months ago

Yes, we should probably do that! My mistake calling this intersection a union 😅