search

epicweb-dev / react-hooks

Learn React Hooks! 🎣 ⚛
https://hooks.epicreact.dev
Other
2.78k stars 1.91k forks source link

Node setup doesn't support Node.js 20 #213

Closed stanulilic closed 1 year ago

stanulilic commented 1 year ago

Hi, I just run node setup on my system(MacOS Ventura), which has Node.js 20 installed. It gives me an error and recommends that I use Node.js 18 or below. Even more confusing is that it recommends that I update to the latest version of Node. But am already using the latest version:

stanley@MACOOKs-MBP react-hooks % node setup
▶️  Starting workshop setup...
      Running the following command: npx "https://gist.github.com/kentcdodds/bb452ffe53a5caa3600197e1d8005733" -q
    ▶️  Starting: System Validation
          Ensuring the correct versions of tools are installed on this computer.
          Running the following command: npx "https://gist.github.com/kentcdodds/abbc32701f78fa70298d444c2303b6d9"
There were errors validating the compatibility of this computer:

    This computer has node@v20.1.0 installed, but node@14 || 16 || 18 is required. Please update node: https://nodejs.org

If you would like to just ignore this error, then feel free to do so and install dependencies as you normally would in "/Users/stanley/react-hooks". Just know that things may not work properly if you do...
    🚨  Failure: System Validation. Please review the messages above for information on how to troubleshoot and resolve this issue.
kentcdodds commented 1 year ago

This should be fixed now. Thanks for reporting!

kentcdodds commented 1 year ago

@all-contributors please add @stanulilic for bugs

allcontributors[bot] commented 1 year ago

@kentcdodds

I've put up a pull request to add @stanulilic! :tada:

stanulilic commented 1 year ago

This should be fixed now. Thanks for reporting!

That's great news. Thanks!