search

epicweb-dev / rocket-rental

Rent Rockets from rocking awesome people
Other
277 stars 34 forks source link

the mistery of glob pattern on windows #11

Closed onemen closed 8 months ago

onemen commented 1 year ago

build-server.ts is used during build process until today i did not try to build an app in the workshops, since the app always starts in development mode, only for testing we need to run the build process.

glob.sync work for me on windows for rocket-rental without the fix of replacing \ with /, i guess it is just the length of the path. in both workshop the path is deeper.

i think it is better to apply the same patch here as well.

one more thing, glob is missing from rocket-rental dependencies/devdependencies as well as for all workshop apps

kentcdodds commented 1 year ago

I'll look into this 👍

onemen commented 1 year ago

same apply to chokidar

chokidar

kentcdodds commented 8 months ago

This is no longer actively maintained, so I'm closing this issue. If you want an up-to-date example of a Remix app that builds on top of what was done here, check the Epic Stack.