search

epicweb-dev / rocket-rental

Rent Rockets from rocking awesome people
Other
277 stars 34 forks source link

This is not a PR #21

Closed szepeviktor closed 1 year ago

szepeviktor commented 1 year ago

This is more like an issue with code.

It should be possible to install the application in production. So everything should be in "dependencies": to go from source code to full production installation.

Currently the installation process mixes devdeps with deps.

szepeviktor commented 1 year ago

I know proper production environments are rare as projects are missing the operations guy.

kentcdodds commented 1 year ago

It's important that development only dependencies are not shipped to the production docker container for a few reasons. Primarily for size. Installing playwright in the docker container and shipping that to prod would be very unnecessary, for example.

This is operating as designed. Thanks anyway!

szepeviktor commented 1 year ago

There is a misunderstanding. I've meant to move production dependencies from devDep to deps in package.json. https://github.com/npm/feedback/discussions/940 👀

kentcdodds commented 1 year ago

Right, and I'm saying we should not do that. We use dev deps to help build our app, then when we go to production we remove those deps and only use the production deps.