search

epicweb-dev / web-auth

Take ownership of you application's authentication and authorization
https://www.epicweb.dev
Other
288 stars 84 forks source link

Toast notifications only work once when deleting notes #30

Closed danielvanc closed 11 months ago

danielvanc commented 11 months ago

When completing the Flash Storage lesson (problem) of the Session Storage module, I noticed when running the app that after you try deleting a note for the 2nd time (without doing a manual page reload), the toast notifications no longer work.

At the very end of the solution step, in the description, you created a utility for managing toast notifications (redirectWithToast), which appears to fix the above issue. It would be great if it could be explained, in the solution step, what the fix was to get that working correctly.

Or perhaps update the problem exercise to have toast notifications working as expected without the utility? Whichever way you think works best for those learning :)

Thanks allot and keep up the great work. 👍🏼

kentcdodds commented 11 months ago

Thank you! I've figured out what the problem was and added a note in the solution: https://github.com/epicweb-dev/web-auth/commit/9cbec1e69f5beeba1e1a53b29feb93684ab60b7e

Thanks a lot!