epidemics / covid

epidemicforcasting.org visualization repository
http://epidemicforecasting.org
GNU Affero General Public License v3.0
20 stars 12 forks source link

Display predicted, actual cases + population on model pages #104

Closed hnykda closed 4 years ago

hnykda commented 4 years ago

Technical

@lagerros is going to compile a fixed JSON indexed by Country, we place that as a file at GCS and render number in the similar way as we now do with the plot or did with countermeasures, or how done by @Mati-Roy here.

Proper data from pipeline will be provided later.

Numbers are 1:

with that note from the #160

UX design

It should look similar to this one: image

jk3141 commented 4 years ago

It shouln't go to the sidebar, but above the graph on the country page (we had it in some deisgn by Jan allready)

hnykda commented 4 years ago

I can't find it in the design, can you point to it here please: https://www.figma.com/file/4FTT6neJVlMD5CQHTTpprF/Covid-%5BWorkFile%5D?node-id=0%3A1

This one is closest (but shows different ones): image

hnykda commented 4 years ago

And by country pages - you mean the models one?

hnykda commented 4 years ago

@gavento you self-assigned yourself, but I don't think you are going to do this, right?

Matoo125 commented 4 years ago

what about this https://github.com/epidemics/covid/pull/160

hnykda commented 4 years ago

I think it's related, but I am not sure. Hence my clarifying questions above. Also #180 seems related.

gavento commented 4 years ago

I am working on the data for this (with Sualeh Asif), but only on the data part. I do not own the web part. Sorry about any confusion here, I am taking on #180 @hnykda

hnykda commented 4 years ago

Issue updated.

wolverdude commented 4 years ago

I just got this working, but I need to break for lunch. I pushed it to this branch, and it looks like this right now:

Screen Shot 2020-03-19 at 12 20 10 PM

Obviously, it could use some styling work, but it updates properly. If anyone wants to mock it up or give feedback on the current appearance, please do so.

I'm also waiting on @epidemics/data to get me the live numbers.

hnykda commented 4 years ago

It looks good to me :+1:

jk3141 commented 4 years ago
wolverdude commented 4 years ago

@jk3141

  • as we don't have nowcasting yet, it should display the date for which the estimates are relevant

I've updated the PR to account for this.

  • displaying uncertainty estimates would be cool, but not if it is difficult to get from foretold

There's only the one FT_Infected number in the data. That said, there's also a JH_Infected, and I'm not sure what it means. I'm assuming the "JH" stands for "Johns Hopkins"?

wolverdude commented 4 years ago

Ah, I see the live data has FT_Infected_q05 and FT_Infected_q95. Yes, I can add in CI.

wolverdude commented 4 years ago

Still waiting on @hnykda or @gavento to upload the live data since neither @lagerros nor I have the privileges.

wolverdude commented 4 years ago

Here's the data, in case someone else has the privileges to upload it. The URLs should look like this when done:

https://storage.googleapis.com/static-covid/static/data-{{CHANNEL}}-estimates-v1.json

@epidemics/data