Closed hnykda closed 4 years ago
It shouln't go to the sidebar, but above the graph on the country page (we had it in some deisgn by Jan allready)
I can't find it in the design, can you point to it here please: https://www.figma.com/file/4FTT6neJVlMD5CQHTTpprF/Covid-%5BWorkFile%5D?node-id=0%3A1
This one is closest (but shows different ones):
And by country pages
- you mean the models
one?
@gavento you self-assigned yourself, but I don't think you are going to do this, right?
what about this https://github.com/epidemics/covid/pull/160
I think it's related, but I am not sure. Hence my clarifying questions above. Also #180 seems related.
I am working on the data for this (with Sualeh Asif), but only on the data part. I do not own the web part. Sorry about any confusion here, I am taking on #180 @hnykda
Issue updated.
I just got this working, but I need to break for lunch. I pushed it to this branch, and it looks like this right now:
Obviously, it could use some styling work, but it updates properly. If anyone wants to mock it up or give feedback on the current appearance, please do so.
I'm also waiting on @epidemics/data to get me the live numbers.
It looks good to me :+1:
@jk3141
- as we don't have nowcasting yet, it should display the date for which the estimates are relevant
I've updated the PR to account for this.
- displaying uncertainty estimates would be cool, but not if it is difficult to get from foretold
There's only the one FT_Infected
number in the data. That said, there's also a JH_Infected
, and I'm not sure what it means. I'm assuming the "JH" stands for "Johns Hopkins"?
Ah, I see the live data has FT_Infected_q05
and FT_Infected_q95
. Yes, I can add in CI.
Still waiting on @hnykda or @gavento to upload the live data since neither @lagerros nor I have the privileges.
Here's the data, in case someone else has the privileges to upload it. The URLs should look like this when done:
https://storage.googleapis.com/static-covid/static/data-{{CHANNEL}}-estimates-v1.json
@epidemics/data
Technical
@lagerros is going to compile a fixed JSON indexed by Country, we place that as a file at GCS and render number in the similar way as we now do with the plot or did with countermeasures, or how done by @Mati-Roy here.
Proper data from pipeline will be provided later.
Numbers are 1:
with that note from the #160
UX design
It should look similar to this one: