search

epidrome / cover-card

:necktie: Online business card with a minimal landing page theme for any social media or online presence account: fork, edit, and go!
https://epidrome.github.io/cover-card/
MIT License
108 stars 109 forks source link

Create test folder for local testing #1

Closed nickgarlis closed 6 years ago

nickgarlis commented 6 years ago

You can use bundle exec jekyll serve inside of the test folder for local development.

epidrome commented 6 years ago

thanks, you can also use:

  1. 'mkdir new-folder'
  2. copy the gh-pages files (or similar ones) into the new-folder
  3. edit the Gemfile with: gem 'cover-card', path: "../cover-card"
  4. bundle install

I understand that the above is way more complicated compared to your proposed solution. Actually your pull request is indeed 'developer friendly', but is there such a need?

I am skeptical because step 3 is the main edit in a pull-request that mostly contains files that already exist or files that may not be relevant to the particular test an advanced developer might want to perform while testing new features for the theme.

I am split between the red pill (above) and the blue pill (PR) solution so I am opening an issue #1 for further discussion before merging or closing.

thanks again!

nickgarlis commented 6 years ago

@epidrome Sure this might not be necessary for some users but I do believe it is important for the theme to be, as you stated, 'developer friendly' . Not to mention that it could be inconvenient for some users to follow all of these steps. If that's the case then they should edit the _config.yml file as well.