search

epidrome / cover-card

:necktie: Online business card with a minimal landing page theme for any social media or online presence account: fork, edit, and go!
https://epidrome.github.io/cover-card/
MIT License
108 stars 109 forks source link

Use profile links from 'social' object #3

Closed aslafy-z closed 6 years ago

aslafy-z commented 6 years ago

While setting up this theme, I figured out that if I'm not using github social, 'site.github' where already defined by github itself. https://help.github.com/articles/repository-metadata-on-github-pages/#available-repository-metadata

I moved all social links to a 'social' object.

This PR comes in two chunks, one per branch.

epidrome commented 6 years ago

nice catch, thanks! I am reluctant to change so many variables in order to fix just one bug. For example the remote theme functionality will break for many existing users, who already have a config file with site.facebook instead of the proposed site.social.facebook.

Nevertheless, I have opened an issue #5 to consider the naming-loop of social icons separately and as a whole. The theme is still in alpha so we might want to introduce major updates as long as they offer significant benefits.

thanks again for reporting this bug!