epidrome / cover-card

:necktie: Online business card with a minimal landing page theme for any social media or online presence account: fork, edit, and go!
https://epidrome.github.io/cover-card/
MIT License
108 stars 109 forks source link

added social networks #7

Closed yashevde closed 6 years ago

yashevde commented 6 years ago

AngelList, Strava, goodreads, Hacker News

epidrome commented 6 years ago
yashevde commented 6 years ago

I see -- that's an interesting design choice. I just added the extra social links to the main social file, as you can see. Wouldn't it make sense to just list all the available options and then provide them to the user?

For more flexibility, I think the username requirement in the config would have to be changed to the entire URL, due to the differences in formatting for URLs with relation to the username on different sites.

Thoughts?

epidrome commented 6 years ago

listing all the available options is probably futile, there will be more social networks in the future, while at the same time even the most popular ones will go extinct, e.g., myspace

i have added your suggestion for full http links instead of username in the respective issue #5, thanks for the feedback!