Possible index error found in function implementation code

epifluidlab / FinaleToolkit

FinaleToolkit is a package and standalone program to extract fragmentation features of cell-free DNA from paired-end sequencing data.

https://epifluidlab.github.io/FinaleToolkit/

MIT License

14 stars 6 forks source link

Possible index error found in function implementation code #106

Closed Upupdownn closed 1 week ago

Upupdownn commented 3 weeks ago

Location src/finaletoolkit/frag/end_motifs.py, line 610 function: region_end_motifs() content

if frag[3]: # is on forward strand or not
    # py2bit uses 0-based for start, 1-based for end
    # forward end-motif

description frag_generator returns a tuple (contig, read_start, read_stop, mapq, read_on_plus) for each iteration. Should the index in the if statement here be [4]?

jamesli124 commented 1 week ago

Issue fixed in FinaleToolkit 0.7.6