search

epiforecasts / EpiNow2

Estimate Realtime Case Counts and Time-varying Epidemiological Parameters
https://epiforecasts.io/EpiNow2/dev/
Other
115 stars 33 forks source link

Testing using rstan develop branch #471

Closed sbfnk closed 1 year ago

sbfnk commented 1 year ago

Current testing is using the rstan develop branch as it would otherwise fail due to an error in the CRAN version.

Corresponding changes are in https://github.com/epiforecasts/EpiNow2/pull/470 and marked with the string "once rstan is updated on CRAN".

seabbs commented 1 year ago

Sorry to be clear there is an error in the CRAN version of R stan that is causing the GitHub version of EpiNow2 to be broken? Or is the CRAN version also broken?

sbfnk commented 1 year ago

Sorry to be clear there is an error in the CRAN version of R stan that is causing the GitHub version of EpiNow2 to be broken?

This (only breaks testing not functionality though). The error is fixed in develop of rstan which will eventually go on CRAN.

seabbs commented 1 year ago

Ty. Which part of testing? I have a few users with hard to explain bugs so just wondering if there is something here.

sbfnk commented 1 year ago

It's exposing stan functions of the _lp type. Can't imagine that will make a difference to any user.

https://github.com/stan-dev/rstan/issues/1093 https://github.com/stan-dev/rstan/issues/1098

seabbs commented 1 year ago

No agree. Oh dear - back to the drawing board

seabbs commented 1 year ago

Also wow that regex - always feels like magic.

sbfnk commented 1 year ago

This is now on CRAN so can be reverted.