epiforecasts / EpiSoon

Forecasting the effective reproduction number over short timescales
https://epiforecasts.io/EpiSoon/
Other
7 stars 3 forks source link

plot_forecast_evaluation() for several regions can't actually plot observed values for several regions #11

Closed nikosbosse closed 4 years ago

nikosbosse commented 4 years ago
plot_forecast_evaluation(evaluations$forecast, observations, c(7)) +
  ggplot2::facet_grid(model ~ region) +
  cowplot::panel_border()

in the example, the function only takes one observation in. instead it should be able to handle a data.frame (or ideally a list, since this is the format that was assigned to timeseries = list(observations, observations) with the observed values for the regions.

seabbs commented 4 years ago

it takes a single data frame as output by compare_timeseries? Think this is working as intended.

Scratch that.... observations should have the region variable and then all works as expected. Could potentially combine in funciton but I think it would be better to change the input for compare_timeseries to be a single dataframe with some grouping applied.

seabbs commented 4 years ago

Done