search

epiforecasts / RtD3

Rt visualisation in D3
https://epiforecasts.io/RtD3/
Other
6 stars 2 forks source link

Widget - bottom text collision #43

Closed hamishgibbs closed 3 years ago

hamishgibbs commented 3 years ago

Text is colliding with the bottom of the widget. Need to increase the default height in:

https://github.com/epiforecasts/RtD3/blob/8a2f13b77dab0da795f5e522f71fc2a2d4ebf075/R/define_height.R#L15-L19

Issue comes from the changes to rt_vis which added some more padding to the time series legend container.

Screenshot 2020-10-16 at 14 57 03

seabbs commented 3 years ago

Are these default heights based on an inspection of Rmds? If that is the case not sure I can think of another approach.

hamishgibbs commented 3 years ago

Yeah - the height (in pixels) of the widget is default but the width is variable. Just need to bump 225px (or the following 100px) to accommodate the new default height. I will open a PR promptly.