search

epiforecasts / covid-rt-estimates

National and subnational estimates of the time-varying reproduction number for Covid-19
https://epiforecasts.io/covid/
MIT License
34 stars 17 forks source link

Full timeseries #197

Closed joeHickson closed 3 years ago

joeHickson commented 3 years ago

add -full versions of all the datasets

closes #15

seabbs commented 3 years ago

Hi Joe, did you test this?

I have spent today trying to debug what has brought down the pipeline. Looking at the logs it looks like sublocation filtering is being triggered even when empty which leads to an empty data frame and a obscure failure message.

The sublocation filter is built out of matching location and includes namin. Running through with debug I get sent to the Canada-full data but the Canada class in the includes list. This leads to a NULL in includes_subregions and an error that matches what I see from the server logs.

Screenshot 2021-05-11 at 10 07 22

joeHickson commented 3 years ago

I tested the full but bet I failed to test an original one...

seabbs commented 3 years ago

no worries the way R6 classes update is pretty damn strange and hard to debug (I think it is one of the reasons they are working on R7).