search

epiforecasts / covidregionaldata

An interface to subnational and national level COVID-19 data. For all countries supported, this includes a daily time-series of cases. Wherever available we also provide data on deaths, hospitalisations, and tests. National level data is also supported using a range of data sources as well as linelist data and links to intervention data sets.
https://epiforecasts.io/covidregionaldata/
Other
37 stars 18 forks source link

Possible approach for #260 #261

Closed RichardMN closed 3 years ago

RichardMN commented 3 years ago

Looking at it, it seems a good way to put in vroom checking is by integrating it into the existing testing of test-regional-dataset.R

Currently this seems to be failing on nearly everything and it has generated a bunch of new datasets in custom-data which I wasn't expecting.

seabbs commented 3 years ago

This does look like a nice idea. I assume the datasets are from having download on and hence it gets overwritten.

I would guess this could be placed outside the download check so that it can be run on a snapshot to see if the error is deterministic.

Not good it's failing everywhere... perhaps printing the problem es on failure might be helpful (though how to actually do that seems tricky).