search

epiforecasts / covidregionaldata

An interface to subnational and national level COVID-19 data. For all countries supported, this includes a daily time-series of cases. Wherever available we also provide data on deaths, hospitalisations, and tests. National level data is also supported using a range of data sources as well as linelist data and links to intervention data sets.
https://epiforecasts.io/covidregionaldata/
Other
37 stars 18 forks source link

Move init to data class #281

Closed joseph-palmer closed 3 years ago

joseph-palmer commented 3 years ago

This moves the function initialise_dataclass into the initialise method of DataClass.

Functionally this seems to work the same way only now country classes call super$initialise rather than initialise_dataclass using the same arguments.

The docs seem to have the same issues as others, in that they don't link to other functions when referenced.

RichardMN commented 3 years ago

There's also an extra ` after WHO in line 319 of shared-methods.R

Which I realize isn't from his PR.

joseph-palmer commented 3 years ago

Awesome cheers guys. I will take car of non-documentation stuff here then merge into #280 and deal with the docs along with the others before requesting review to merge into master.