Closed joseph-palmer closed 3 years ago
👋 Thanks for opening this pull request! Can you please run through the following checklist before requesting review (ticking as complete or if not relevant).
devtools::load_all(); devtools::test()
) first setting options(testDownload=TRUE, testSource=class-name)
and report your findings. devtools::load_all(); devtools::test()
). Thank you again for the contribution. If making large scale changes consider using our pre-commit
hooks (see the contributing guide) to more easily comply with our guidelines.
Vectorises key functions in processing.
complete_cumulative_columns
calculate_columns_from_existing_data
Had to go with a global variable assignment in
complete_cumulative_columns
(if anyone knows of a better what to acheive this please let me know!)closes #277