epiforecasts / covidregionaldata

An interface to subnational and national level COVID-19 data. For all countries supported, this includes a daily time-series of cases. Wherever available we also provide data on deaths, hospitalisations, and tests. National level data is also supported using a range of data sources as well as linelist data and links to intervention data sets.
https://epiforecasts.io/covidregionaldata/
Other
37 stars 18 forks source link

Additional tests #307

Closed joseph-palmer closed 2 years ago

joseph-palmer commented 3 years ago

WIP

This Branch acts as a place to merge PRs for additional tests (listed in #302). If you are working on a test please write your name next to it on the checklist with the pr number for it.

To get started I have added tests that region names are not all NA.

closes #302

github-actions[bot] commented 3 years ago

👋 Thanks for opening this pull request! Can you please run through the following checklist before requesting review (ticking as complete or if not relevant).

Thank you again for the contribution. If making large scale changes consider using our pre-commit hooks (see the contributing guide) to more easily comply with our guidelines.

seabbs commented 3 years ago

I imagine this has some conflicts with recent package changes? Should we pause on this for now and or pull the code out elsewhere? It might be worth having a little think about data integrity checks in general (i.e a validate check of a data source separate from "unit" testing etc). It would be nice to increase data specific testing. Same goes for #312.

github-actions[bot] commented 3 years ago

This PR has been flagged as stale due to lack of activity