Closed joseph-palmer closed 2 years ago
👋 Thanks for opening this pull request! Can you please run through the following checklist before requesting review (ticking as complete or if not relevant).
devtools::load_all(); devtools::test()
) first setting options(testDownload=TRUE, testSource=class-name)
and report your findings. devtools::load_all(); devtools::test()
). Thank you again for the contribution. If making large scale changes consider using our pre-commit
hooks (see the contributing guide) to more easily comply with our guidelines.
I imagine this has some conflicts with recent package changes? Should we pause on this for now and or pull the code out elsewhere? It might be worth having a little think about data integrity checks in general (i.e a validate check of a data source separate from "unit" testing etc). It would be nice to increase data specific testing. Same goes for #312.
This PR has been flagged as stale due to lack of activity
WIP
This Branch acts as a place to merge PRs for additional tests (listed in #302). If you are working on a test please write your name next to it on the checklist with the pr number for it.
To get started I have added tests that region names are not all NA.
closes #302