Fix UK NHS data - Githubissues

epiforecasts / covidregionaldata

An interface to subnational and national level COVID-19 data. For all countries supported, this includes a daily time-series of cases. Wherever available we also provide data on deaths, hospitalisations, and tests. National level data is also supported using a range of data sources as well as linelist data and links to intervention data sets.

https://epiforecasts.io/covidregionaldata/

Other

37 stars 18 forks source link

Fix UK NHS data #326

Closed kathsherratt closed 3 years ago

kathsherratt commented 3 years ago

Fixes data download issue with NHS hospital data for England / English regions.

Data are now available as two excel sheets to be downloaded separately

Data from 7 April 2021 available from the same dynamic url that we had set up
Data for 8 Aug 2020 - 6 Apr 2021 available from a stable url in an excel sheet in the same format

This PR

Adds the stable url for archive data to the UK R6 object
Edits the UK download function to get both archive and recent data
Raw archive and raw recent data are joined together (but no more) in the download function
All cleaning steps continue to work as normal on the joined data

Tests updated and pass

github-actions[bot] commented 3 years ago

👋 Thanks for opening this pull request! Can you please run through the following checklist before requesting review (ticking as complete or if not relevant).

[x] Read our contribution guidelines if you have not already done so.
- [x] If you have altered an existing class please run the tests locally (using devtools::load_all(); devtools::test()) first setting options(testDownload=TRUE, testSource=class-name) and report your findings.
- [x] If you have added a new data class please run the tests locally for that class (using devtools::load_all(); devtools::test()).
- [x] Check your code passes our CI checks and review any style and code coverage warnings.
- [x] Comment with details if unable to get our CI checks to pass or unable to remove all warnings.

Thank you again for the contribution. If making large scale changes consider using our pre-commit hooks (see the contributing guide) to more easily comply with our guidelines.

kathsherratt commented 3 years ago

Ooh I was just working on this and saw your changes @seabbs. I like pulling out a download_excel function, that seems handy to have around. Thanks!

seabbs commented 3 years ago

Sorry Kath I meant to comment that I was doing it! Had a meeting on mute where I thought I should do something other than smile vacantly!

seabbs commented 3 years ago

👯 merging now.

Kath be good to think about pain points or issues that mad you less than joyful with this PR as this kind of change would be great to get from externals who are watching the data so making it nice would be nice.