Closed joseph-palmer closed 3 years ago
👋 Thanks for opening this pull request! Can you please run through the following checklist before requesting review (ticking as complete or if not relevant).
devtools::load_all(); devtools::test()
) first setting options(testDownload=TRUE, testSource=class-name)
and report your findings. devtools::load_all(); devtools::test()
). Thank you again for the contribution. If making large scale changes consider using our pre-commit
hooks (see the contributing guide) to more easily comply with our guidelines.
Removes
common_data_urls
from the expected country fields oftest-check_country_class
and adds a new test that eithercommon_data_urls
orlevel_data_urls
is defined in each class. Also removedcommon_data_urls
from classes where it was empty and only there to pass the previous tests.closes #339