search

epiforecasts / covidregionaldata

An interface to subnational and national level COVID-19 data. For all countries supported, this includes a daily time-series of cases. Wherever available we also provide data on deaths, hospitalisations, and tests. National level data is also supported using a range of data sources as well as linelist data and links to intervention data sets.
https://epiforecasts.io/covidregionaldata/
Other
37 stars 18 forks source link

Lithuania ignores optional params #341

Closed RichardMN closed 3 years ago

RichardMN commented 3 years ago

Not sure how I missed this at the time but I think I put super$initialize before the application of optional params into public variables in initialize for Lithuania, meaning that the optional params don't get written and somehow the code short-circuits when it's called the second time.

initialize gets called with default params, I think when we're building the list of available datasets; when it's called the second time it seems to go from super$initialize to download, clean and process.

All to say that there's a problem with the Lithuania code, I think I know what it is, and I hope to have a PR shortly.

seabbs commented 3 years ago

Ah great spot. This seems like an easy issue to introduce with new classes so good to think about how we can explore it going forward/test for it.