Closed joseph-palmer closed 3 years ago
👋 Thanks for opening this pull request! Can you please run through the following checklist before requesting review (ticking as complete or if not relevant).
devtools::load_all(); devtools::test()
) first setting options(testDownload=TRUE, testSource=class-name)
and report your findings. devtools::load_all(); devtools::test()
). Thank you again for the contribution. If making large scale changes consider using our pre-commit
hooks (see the contributing guide) to more easily comply with our guidelines.
Error caused by
select(where( ~ !all(is.na(.x)))
. This was used to remove level columns not requested (e.g. if level 2 was requested this was designed to not select level 3 columns) by rejecting columns that are all NAs. The problem is that with the snapshot other columns that are used were composed of all NAs. This meant the code worked in full but not with the snapshot.This PR replaces the removal of NA columns in cleaning with a removal of level columns not requested.
closes #347