New joss comments - Githubissues

epiforecasts / covidregionaldata

An interface to subnational and national level COVID-19 data. For all countries supported, this includes a daily time-series of cases. Wherever available we also provide data on deaths, hospitalisations, and tests. National level data is also supported using a range of data sources as well as linelist data and links to intervention data sets.

https://epiforecasts.io/covidregionaldata/

Other

37 stars 18 forks source link

New joss comments #367

Closed joseph-palmer closed 3 years ago

joseph-palmer commented 3 years ago

This PR is for the latest JOSS comments

[x] More up to date reference for R core team
[x] Reword extensible / extend paper lines 16-17
[x] make 'changes to dependency package' more explicit
[x] highlight github actions for testing of data sets
[x] versions for sars2pack and covdata pluss DOIs (Not provided by the packages, citations provided by the package, only what they have listed is avaliable.
[x] $ after Palmer
[x] statement of target audiance in readme
[ ] Add statement of 'To Recreate vignettes use dependency = TRUE'
[x] Point to issue about docs linking to case study to expand on point of more documentation
[ ] Point to issues of creating more tests and fixing current bug
[ ] Vignettes not being rendered
[ ] Replace vignettes with eval but only evaluate if the code produces an output, if not shown hide code to keep runtime fast

github-actions[bot] commented 3 years ago

👋 Thanks for opening this pull request! Can you please run through the following checklist before requesting review (ticking as complete or if not relevant).

[x] Read our contribution guidelines if you have not already done so.
- [x] If you have altered an existing class please run the tests locally (using devtools::load_all(); devtools::test()) first setting options(testDownload=TRUE, testSource=class-name) and report your findings.
- [x] If you have added a new data class please run the tests locally for that class (using devtools::load_all(); devtools::test()).
- [x] Check your code passes our CI checks and review any style and code coverage warnings.
- [x] Comment with details if unable to get our CI checks to pass or unable to remove all warnings.

Thank you again for the contribution. If making large scale changes consider using our pre-commit hooks (see the contributing guide) to more easily comply with our guidelines.

joseph-palmer commented 3 years ago

I think this is good to go, the only thing I have not done is the vignette stuff as this should be updated along with the docs (such as #314 #316)

joseph-palmer commented 3 years ago

Iv'e updated for changes, except for the citation as I don't think we have one for JOSS yet? Unsure on this

Once happy can you give the google doc one last scan to make sure I'm correct on everything, after which I will post the response.

seabbs commented 3 years ago

Read the responses again and all looks good. Only thing I think we really should do is the slowstart vignette change.

joseph-palmer commented 3 years ago

Is this all good for the vignettes?