Closed kathsherratt closed 3 years ago
👋 Thanks for opening this pull request! Can you please run through the following checklist before requesting review (ticking as complete or if not relevant).
devtools::load_all(); devtools::test()
) first setting options(testDownload=TRUE, testSource=class-name)
and report your findings. devtools::load_all(); devtools::test()
). Thank you again for the contribution. If making large scale changes consider using our pre-commit
hooks (see the contributing guide) to more easily comply with our guidelines.
Jumped in and squished those minor issues as so minor. Merging now - great stuff :)
Thanks so much!
NHS data sometimes doesn't update e.g. on bank holidays.
This PR adds a small piece in
download_nhs_regions()
to make the download more robust to recent missing data / broken links.release_date
(our existing default isSys.Date()-1
)nhs_recent_url
, which continues in existing pipelinePotentially fixes #370