Fix argument name in vignette

[Bisaloo]

On a related note, why is this vignette set to eval = FALSE? Using eval = TRUE would prevent this kind of errors and ensure the displayed output match the real output (even after updates).

[github-actions[bot]]

👋 Thanks for opening this pull request! Can you please run through the following checklist before requesting review (ticking as complete or if not relevant).

• [ ] Read our contribution guidelines if you have not already done so.
  • [ ] If you have altered an existing class please run the tests locally (using devtools::load_all(); devtools::test()) first setting options(testDownload=TRUE, testSource=class-name) and report your findings.
  • [ ] If you have added a new data class please run the tests locally for that class (using devtools::load_all(); devtools::test()).
  • [ ] Check your code passes our CI checks and review any style and code coverage warnings.
  • [ ] Comment with details if unable to get our CI checks to pass or unable to remove all warnings.

Thank you again for the contribution. If making large scale changes consider using our pre-commit hooks (see the contributing guide) to more easily comply with our guidelines.

[seabbs]

Thanks for this and yes I agree. The reason is that building them with downloaded data can be error prone and we wanted to be hyper careful that we stayed on CRAN. That being said @joseph-palmer is turning on some of these chunks in #367 but its a bit of an open question of many of them.

[Bisaloo]

To deal with long runtime vignettes and fetching online data that might be unavailable, I've had success with pre-rendering vignettes. Otherwise, you can cache the data with vcr and webmockr but it is usually too much trouble if just used in the vignette in my opinion.