Closed joseph-palmer closed 3 years ago
👋 Thanks for opening this pull request! Can you please run through the following checklist before requesting review (ticking as complete or if not relevant).
devtools::load_all(); devtools::test()
) first setting options(testDownload=TRUE, testSource=class-name)
and report your findings. devtools::load_all(); devtools::test()
). Thank you again for the contribution. If making large scale changes consider using our pre-commit
hooks (see the contributing guide) to more easily comply with our guidelines.
Made the recomended changes and updates the version, however I was not sure what to write in the news section under the latest version 0.9.3
This PR impliments final checks for the JOSS submission and are as follows:
I have updated the DESCRIPTION with the paper title and author lists to reflect the paper and repeated this for the CITATION. In the citation I have filled in for the JOSS as much as I can, putting in the issue number and page number etc. I have left the DOI blank though as I think we need to wait until this is out before we can add this in? The other JOSS info may also need updating when this happens.
closes #391