search

epiforecasts / covidregionaldata

An interface to subnational and national level COVID-19 data. For all countries supported, this includes a daily time-series of cases. Wherever available we also provide data on deaths, hospitalisations, and tests. National level data is also supported using a range of data sources as well as linelist data and links to intervention data sets.
https://epiforecasts.io/covidregionaldata/
Other
37 stars 18 forks source link

Alternate fix colombia data 430 which makes RSocrata suggested #433

Closed RichardMN closed 2 years ago

RichardMN commented 2 years ago

This includes code in the Colombia class which uses require so that the RSocrata package is used if it is present but there is a work-around if it is not. This means that RSocrata doesn't need to be required in DESCRIPTION which makes this package more lightweight for those who may not want to download Colombia regional data and wouldn't want to have to install RSocrata to support functionality they don't want to use.

kathsherratt commented 2 years ago

This makes sense to me, great to have the extra package as a suggest since in this case having both options doesn't add too much in extra workarounds.

This works fine locally. Re the failing check here, I ran devtools::check() and got no errors/warnings/notes, just slightly updated docs so I guess it's just that.

I suggest updating docs, closing #432 and merge in. Thank you very much Richard!

github-actions[bot] commented 2 years ago

This PR has been flagged as stale due to lack of activity