Closed Bisaloo closed 2 years ago
👋 Thanks for opening this pull request! Can you please run through the following checklist before requesting review (ticking as complete or if not relevant).
devtools::load_all(); devtools::test()
) first setting options(testDownload=TRUE, testSource=class-name)
and report your findings. devtools::load_all(); devtools::test()
). Thank you again for the contribution. If making large scale changes consider using our pre-commit
hooks (see the contributing guide) to more easily comply with our guidelines.
To keep it under the 20 packages limit enforced by CRAN (fix #434).
progress
) to a function where...
are already forwarded. You run the risk of having a issue dof(progress = FALSE)
and then get a warning about an argument being supplied multiple times. But, in this specific case, given that the function is exclusively used internally, I think it's okay.I would like to remove tidyselect as well but I'm a little bit perplexed about the strange case of
where()
. It doesn't seem to be explicitly re-exported from dplyr but:Created on 2021-11-30 by the reprex package (v2.0.1.9000)
It's probably some tidyeval magick but it also means that we will probably get a warning about
where
being a global variable if we try it in the package. Maybe the best course of action is to ask dplyr devs if they could explicitly re-exportwhere()
, as they do for all the other tidyselect functions(??)