Closed Bisaloo closed 2 years ago
👋 Thanks for opening this pull request! Can you please run through the following checklist before requesting review (ticking as complete or if not relevant).
devtools::load_all(); devtools::test()
) first setting options(testDownload=TRUE, testSource=class-name)
and report your findings. devtools::load_all(); devtools::test()
). Thank you again for the contribution. If making large scale changes consider using our pre-commit
hooks (see the contributing guide) to more easily comply with our guidelines.
Additionally, the required tests use ubuntu-20.04
when the new tests use ubuntu-latest
.
There is a gap in our coverage where we jump directly from
oldrel-1
torelease
.This is also a problem because
oldrel
is defined as a required test to merge PRs. Since this test doesn't exist, PRs never reach the stage where they can be merged (excepted if an admin bypasses the test requirements).