Closed seabbs closed 2 years ago
Merging #101 (f2eaa27) into main (01d9e57) will decrease coverage by
7.82%
. The diff coverage is42.63%
.
@@ Coverage Diff @@
## main #101 +/- ##
==========================================
- Coverage 95.19% 87.36% -7.83%
==========================================
Files 11 13 +2
Lines 707 815 +108
==========================================
+ Hits 673 712 +39
- Misses 34 103 +69
Impacted Files | Coverage Δ | |
---|---|---|
R/check.R | 85.00% <ø> (ø) |
|
R/data-scenarios.R | 100.00% <ø> (ø) |
|
R/forecast-methods.R | 0.00% <0.00%> (ø) |
|
R/posterior-methods.R | 0.00% <0.00%> (ø) |
|
R/utils.R | 75.00% <22.22%> (-25.00%) |
:arrow_down: |
R/postprocess.R | 98.63% <95.83%> (+0.08%) |
:arrow_up: |
R/forecast-tools.R | 100.00% <100.00%> (ø) |
|
R/forecast.R | 92.85% <100.00%> (+0.43%) |
:arrow_up: |
R/plot.R | 91.48% <100.00%> (+3.42%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 01d9e57...f2eaa27. Read the comment docs.
This PR adds a S3 method workflow and streamlines the lower level workflow. It builds on top of (and fixes issues with #100)
Features
summary
andplot
methods forforecast()
andfc_tidy_posterior()
as interfaces to lower level functions.fv_tidy_posterior()
.plot_voc_advantage()
to extract and plot this.plot_voc_advantage()
toplot_posterior
as an additional output.Breaking changes
voc_frac
fromvoc
due to the new variant advantage label.plot_voc()
has been renamedplot_voc_frac()
due to the newplot_voc_advantage()
function.Bug fixes
voc_label
was not being passed byforecast()
to lower level methods and hence new labels specifying the VOC were not being assigned.