search

epiforecasts / scoringutils

Utilities for Scoring and Assessing Predictions
https://epiforecasts.io/scoringutils/
Other
47 stars 20 forks source link

Improve code coverage #686

Open nikosbosse opened 4 months ago

nikosbosse commented 4 months ago

We should aim to increase our code coverage and bring it back up.

~Specifically, we should double-check the codecov report from #583 - codecov complained that a few lines were not covered even though I think they are.~ Update: done in #703 and #704

seabbs commented 4 months ago

Specifically, we should double-check the codecov report from https://github.com/epiforecasts/scoringutils/pull/583 - codecov complained that a few lines were not covered even though I think they are.

If that is the case are you thinking there is a bug in code coverage, a bug in how our coverage is being collected, or a bug in our test setup (so not everything is called). I think this might warrant a further issue as its separate from the low coverage problems imo

nikosbosse commented 4 months ago

If that is the case are you thinking there is a bug in code coverage, a bug in how our coverage is being collected, or a bug in our test setup (so not everything is called). I think this might warrant a further issue as its separate from the low coverage problems IMO

Against all odds, this error might be rooted in human error.. 🙈 Discussed in #703 and fixed in #704.