epiforecasts / scoringutils

Utilities for Scoring and Assessing Predictions
https://epiforecasts.io/scoringutils/
Other
48 stars 20 forks source link

Issue #245 - add additional input checks to `plot_correlations()` #729

Closed nikosbosse closed 5 months ago

nikosbosse commented 5 months ago

Description

This PR closes #245.

245 notes that you don't get a very informative error message if you pass something that's not the output of get_correlations() to plot_correlations().

This PR

I assume there would be potential to make all of this more sophisticated, but I think for now it should do the trick.

[Describe the changes that you made in this pull request.]

Checklist

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.34%. Comparing base (2ac7a6b) to head (da13115).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #729 +/- ## ========================================== + Coverage 95.32% 95.34% +0.01% ========================================== Files 21 21 Lines 1648 1655 +7 ========================================== + Hits 1571 1578 +7 Misses 77 77 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.