Closed nikosbosse closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.36%. Comparing base (
488fa25
) to head (f30b961
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Probably the overhead is mostly code duplication (i.e. a function with checks calling another function with checks)
Description
This PR closes #744.
From #744:
This PR fixes the error by adding an
ensure_data.table()
statement tocheck_number_per_forecast()
in which the input gets copied once. That causes some overhead, but it fixes the error 🤷 .I briefly thought about adding an input check for the
forecast_unit
argument. But then I remembered that I am a good boi and don't do unrelated changes and reverted it. Maybe worth having a general discussion about whether or not we want input checks for internal functions? On the one hand they don't seem strictly necessary as we can control their use, but then again it doesn't cause much overhead.Checklist
lintr::lint_package()
to check for style issues introduced by my changes.