Open nikosbosse opened 5 months ago
Is this all done now?
We did another set of renaming/restructuring files previously, this one is still open.
get_-functions.R
also contains some assert_...
and test_...
functions which I think should be moved to one of the check-....R
fiiles.
@nikosbosse You could perhaps do this as a final step before release since it's not a functional change?
Following one of Sam's suggestions, we should think about moving all the files related to one forecast class to one file (i.e. everything related to converting into a forecast and assertions and tests and checks etc.)
I really like this from the view of thinking about implementing new classes as the process to do so is then copy a single file that you know contains everything you need to create and then work through doing so. I can see the argument that it might be hard to get an impression of the overall package structure though
Following one of Sam's suggestions, we should think about moving all the files related to one forecast class to one file (i.e. everything related to converting into a forecast and assertions and tests and checks etc.)
Agreed. It makes it easier to find everything about the class in one place. See dist_spec.R for example.
I really like this from the view of thinking about implementing new classes as the process to do so is then copy a single file that you know contains everything you need to create and then work through doing so. I can see the argument that it might be hard to get an impression of the overall package structure though
That's how I learnt to develop classes actually.
convencience-functions.R
should be renamed totransform_forecasts.R
set_forecast_unit()
should be moved to a fileget_forecast_unit.R
(maybeforecast_unit.R
?) together withget_forecast_unit()
.correlations.R
should beget_correlations.R
get_
-functions should be moved out ofget_-functions.R
metrics-range.R
-->metrics-interval_range.R
customise_metric()
should maybe get its own file. Alternatively, the corresponding tests should be moved.validate_scores
should really beassert_scores()