Closed nikosbosse closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.30%. Comparing base (
a3c70c9
) to head (9521f84
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR turned out to be a bit of a monster, unfortunately. If you like I'm happy to split it up a bit. That wouldn't change the overall quantity, but maybe it's nicer to review.
Description
This PR closes #425. This PR closes ##702.
This PR
@
args be? I think it's a step in the right direction, but the path is long and cumbersomeas_forecast()
in particular, adding the table from the paper with the different formats. Currently, bothas_forecast()
andscore()
have that info. We could delete it fromscore()
or leave it there. Any opinions? (I also added some duplicated info toget_forecast_type()
andget_forecast_unit()
, but I think that's helpful..I will have to update the inputs to
quantile_score()
once again, but I'll do that when I get to working on the input checks (#748).Here are several emotional damage platypus:
And a baby toucan for good measure:
Checklist
lintr::lint_package()
to check for style issues introduced by my changes.