epiforecasts / scoringutils

Utilities for Scoring and Assessing Predictions
https://epiforecasts.io/scoringutils/
Other
48 stars 20 forks source link

Rethink the way arguments are passed in `get_pairwise_comparisons()` #769

Open nikosbosse opened 4 months ago

nikosbosse commented 4 months ago

As discussed in https://github.com/epiforecasts/scoringutils/pull/737, there are a few things that we could improve/make clearer related to the workflow of get_pairwise_comparisons().

In particular this concerns the way users can change the default test to apply for getting p-values (wilcoxon or permutation test) as well as the null hypothesis for the permutation test. Seb previously suggested the following:

Also given the prominence of the test type in the documentation perhaps make test_type an explicit argument rather than passing it via ellipsis?

seabbs commented 4 months ago

Also given the prominence of the test type in the documentation perhaps make test_type an explicit argument rather than passing it via ellipsis?

Agree