epiforecasts / scoringutils

Utilities for Scoring and Assessing Predictions
https://epiforecasts.io/scoringutils/
Other
48 stars 20 forks source link

change `data` to `forecast` in `score()` and update related tests #772

Closed nikosbosse closed 4 months ago

nikosbosse commented 4 months ago

Description

This PR closes #.

The validate_general() is a bit of an edge case. Context:

Since the function doesn't require a forecast object (although it requires a data.table I'm leaning towards calling the first arg data instead of forecast. This would be analogously to e.g. as_forecast() or get_forecast_unit(), which also don't require a forecast object.

Checklist

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.31%. Comparing base (b56cf28) to head (fa538c7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #772 +/- ## ========================================== + Coverage 95.30% 95.31% +0.01% ========================================== Files 21 21 Lines 1598 1602 +4 ========================================== + Hits 1523 1527 +4 Misses 75 75 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nikosbosse commented 4 months ago

I like the idea. validate_forecast_all()?

nikosbosse commented 4 months ago

New issue for this discussion: https://github.com/epiforecasts/scoringutils/issues/773