Closed nikosbosse closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.31%. Comparing base (
b56cf28
) to head (fa538c7
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I like the idea.
validate_forecast_all()
?
New issue for this discussion: https://github.com/epiforecasts/scoringutils/issues/773
Description
This PR closes #.
data
toforecast
in the following functionsscore()
validate_forecast()
(but notvalidate_general()
)get_forecast_counts()
get_pit()
sample_to_quantile()
interval_long_to_quantile()
quantile_to_interval()
transform_forecasts()
The
validate_general()
is a bit of an edge case. Context:validate_forecast()
methodsSince the function doesn't require a
forecast
object (although it requires adata.table
I'm leaning towards calling the first argdata
instead offorecast
. This would be analogously to e.g.as_forecast()
orget_forecast_unit()
, which also don't require a forecast object.Checklist
lintr::lint_package()
to check for style issues introduced by my changes.