Issue #754 - Drop function `merge_and_pred_obs()`

nikosbosse commented 4 months ago

Description

This PR closes #754.

The PR

deletes the function merge_and_pred_obs()
moves the code to a new Vignette "Deprecated functions". We already have "Deprecated visualisations", so "Deprecated functions might either be a great or a terrible name...
deletes two example data sets, one with truth data only and the other one with quantile forecasts only. These were there to illustrate merging predictions and observations
updates tests (and drops the tests for merge_pred_and_obs()

Checklist

[x] My PR is based on a package issue and I have explicitly linked it.
[x] I have included the target issue or issues in the PR title as follows: issue-number: PR title
[x] I have tested my changes locally.
[x] I have added or updated unit tests where necessary.
[x] I have updated the documentation if required.
[x] I have built the package locally and run rebuilt docs using roxygen2.
[x] My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
[x] I have added a news item linked to this PR.
[x] I have reviewed CI checks for this PR and addressed them as far as I am able.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.53%. Comparing base (f61f7fb) to head (4d23613).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #776 +/- ## ========================================== + Coverage 95.30% 95.53% +0.22% ========================================== Files 21 21 Lines 1598 1567 -31 ========================================== - Hits 1523 1497 -26 + Misses 75 70 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nikosbosse commented 4 months ago

This was auto-merged, right? If so I'll reopen and apply your suggestions

seabbs commented 4 months ago

err yes but I would have thought it should have been blocked by the unresolved conversations. I will change the branch protection for now for the future.

seabbs commented 4 months ago

Done - to merge now will need all conversations to have been resolved.

epiforecasts / scoringutils