Closed nikosbosse closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.60%. Comparing base (
aa01cad
) to head (573166d
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Should as_forecast() get a silent argument as well? We have quite a large number of suppressMessages() calls in our tests, which maybe is a hint...
I think if we rename it to be verbose
then yes
Latest update:
cli_warn()
silent
to verbose
verbose
statements actually get passed on to assert_forecast()
assert_forecast()
is in silent mode)
Description
This PR closes #688. This PR closes #689.
This PR closes #773.
In #688 and in particular in #753 we discussed the relationship between
validate_forecast()
andas_forecast()
and decided on the following:as_forecast()
converts from a non-forecast
object to aforecast
object, validates it and returns the objectassert_forecast()
re-validates an existingforecast
object and returnsinvisble(NULL)
validate_forecast()
is likeassert_forecast()
, but returns the object so it can be used in a pipe.This PR
validate_forecast()
toassert_forecast()
and changed it to returninvisble(NULL)
silent
argument tovalidate_forecast()
(that effectively prevents one single message from being thrown)silent
argument, e.g. when printingvalidate_forecast()
function that callsassert_forecast()
and returns the datavalidate_general()
toassert_forecast_generic()
Further question: Should
as_forecast()
get asilent
argument as well? We have quite a large number ofsuppressMessages()
calls in our tests, which maybe is a hint...[Describe the changes that you made in this pull request.]
Checklist
lintr::lint_package()
to check for style issues introduced by my changes.