epiforecasts / scoringutils

Utilities for Scoring and Assessing Predictions
https://epiforecasts.io/scoringutils/
Other
48 stars 20 forks source link

Issue #688 - Reorganise `validate_forecast()` #778

Closed nikosbosse closed 4 months ago

nikosbosse commented 4 months ago

Description

This PR closes #688. This PR closes #689.
This PR closes #773.

In #688 and in particular in #753 we discussed the relationship between validate_forecast() and as_forecast() and decided on the following:

This PR

Further question: Should as_forecast() get a silent argument as well? We have quite a large number of suppressMessages() calls in our tests, which maybe is a hint...

[Describe the changes that you made in this pull request.]

Checklist

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.60%. Comparing base (aa01cad) to head (573166d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #778 +/- ## ========================================== + Coverage 95.53% 95.60% +0.06% ========================================== Files 21 21 Lines 1567 1569 +2 ========================================== + Hits 1497 1500 +3 + Misses 70 69 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

seabbs commented 4 months ago

Should as_forecast() get a silent argument as well? We have quite a large number of suppressMessages() calls in our tests, which maybe is a hint...

I think if we rename it to be verbose then yes

nikosbosse commented 4 months ago

Latest update: