epiforecasts / scoringutils

Utilities for Scoring and Assessing Predictions
https://epiforecasts.io/scoringutils/
Other
47 stars 19 forks source link

Issue #828 - Allow `score()` to succeed even if some scores can't be computed #829

Closed nikosbosse closed 1 month ago

nikosbosse commented 1 month ago

Description

This PR closes #828.

As discussed in #828, rbindlist causes score to crash if some score can't be computed in a subset of forecasts. Given that we generally catch errors, I suggest adding fill = TRUE in rbindlist.

[Describe the changes that you made in this pull request.]

Checklist

nikosbosse commented 1 month ago

@seabbs I need that fix for some Metaculus stuff I'm running, so I'm planning to merge it later today unless you protest loudly. Apologies for the late-evening message!

Also of course open to discussing this again in a separate issue!

nikosbosse commented 1 month ago

Merci! <3