epiforecasts / scoringutils

Utilities for Scoring and Assessing Predictions
https://epiforecasts.io/scoringutils/
Other
47 stars 19 forks source link

Issue #821 - Remove digits argument from get_correlations #834

Closed nikosbosse closed 1 month ago

nikosbosse commented 1 month ago

Description

This PR closes #821.

This PR moves digits argument from get_correlations to plot_correlations. Removing the digits was discussed in #821. I think it makes sense to move it to plot_correlations() - ultimately, I can't really imagine a case in which one would like to plot correlations without rounding them.

Checklist

nikosbosse commented 1 month ago

I just checked and we never had that argument anywhere specifically. The old correlation function just did it by default...

nikosbosse commented 1 month ago

Added a news item now

jamesmbaazam commented 1 month ago

I just checked and we never had that argument anywhere specifically. The old correlation function just did it by default...

That's great; no deprecation is needed.