epiforecasts / scoringutils

Utilities for Scoring and Assessing Predictions
https://epiforecasts.io/scoringutils/
Other
48 stars 20 forks source link

Render Readme fails #861

Closed nikosbosse closed 1 month ago

nikosbosse commented 1 month ago

Adding contributors in the automated readme seems to fail...

Error in if (x[contribs_sec + 1] == "^-+$") { : 
  missing value where TRUE/FALSE needed
Calls: <Anonymous> -> add_contribs_to_files -> add_contribs_to_one_file
Execution halted
★  Extracting code contributors★  Extracting github issue contributors★  Checking GitHub URLs

@sbfnk any idea what causes the error?

https://github.com/epiforecasts/scoringutils/actions/runs/9959596910

sbfnk commented 1 month ago

Yes, this is a bug in allcontributors (will report it there now). The ## Contributors line can't be the last one in the file. If you insert an empty new line afterwards you should be fine.

nikosbosse commented 1 month ago

Hmm the .Rmd file currently has an empty new line if I'm not completely mistaken....

sbfnk commented 1 month ago

Nope https://github.com/epiforecasts/scoringutils/blob/47040f1ecc3cb913b679b9e436524127a7b655bc/README.Rmd#L158

nikosbosse commented 1 month ago

interesting! This is what it shows you when you press "edit"

image