Closed MichaelChirico closed 3 months ago
@MichaelChirico thanks a lot for your recent contributions - much appreciate it. If you like, please add yourself as a contributor to the package DESCRIPTION.
If you like, please add yourself as a contributor to the package DESCRIPTION.
Don't feel I've contributed all that much, but thank you for the offer! And thanks for using data.table 👍
FYI data.table will release to CRAN in August, so expect to need a {scoringutils} update in the near future. Thanks again!
Part of https://github.com/Rdatatable/data.table/issues/6284.
The message upstream has been improved (here):
This will be released to CRAN soon. In general, it is a bit fragile to rely on the exact wording of another package's errors/warnings/messages. See here for how we try and be a bit more flexible in {data.table} when relying on {base} message text:
https://github.com/Rdatatable/data.table/blob/a01f00f7438daf4612280d6886e6929fa8c8f76e/inst/tests/tests.Rraw#L160-L202
Eventually, we'd like to offer you custom condition classes you can more reliably depend on instead:
https://github.com/Rdatatable/data.table/issues/5913
In fact we already do so for the particular message you're relying on:
dt_missing_fun_aggregate_warning
:https://github.com/Rdatatable/data.table/blob/0030b15d1ebc9242e30159351388ef3cc114e344/R/fcast.R#L185